RFR: 8329031: CPUID feature detection for Advanced Performance Extensions (Intel® APX) [v2]
Jatin Bhateja
jbhateja at openjdk.org
Fri Jun 7 02:16:27 UTC 2024
On Thu, 6 Jun 2024 20:26:43 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comments resolutions.
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 1052:
>
>> 1050:
>> 1051: // Currently APX support is only enabled for targets supporting AVX512VL feature.
>> 1052: if (UseAPX && (!supports_apx_f() || !supports_avx512vl())) {
>
> This code should be after UseAVX checks.
Its purposefully placed after modifications to CPU_* features flags if user explicitly sets UseAVX < 3.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18562#discussion_r1630536165
More information about the hotspot-compiler-dev
mailing list