RFR: 8329031: CPUID feature detection for Advanced Performance Extensions (Intel® APX) [v3]

[Jatin Bhateja]

On Fri, 7 Jun 2024 02:45:01 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments addressed.
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 443:
> 
>> 441: 
>> 442:     /* FIXME: Uncomment while integrating JDK-8329032
>> 443:     bool save_apx = UseAPX;
> 
> What are you missing to uncomment this code?
> 8329032 is about `.ad` file changes. It should not affect execution of this code. 
> You need changes in `register_x86.*` files and may be somewhere else but you don't need C2 changes for this code to work.

Yes, we already have that in place with https://github.com/openjdk/jdk/pull/19042, which will be open for review after this patch.  I added it in comments since this piece of logic is centered around CPUID feature check and pertinent to this patch.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18562#discussion_r1630611657