RFR: 8333893: Optimization for StringBuilder append boolean & null

[Dean Long]

On Mon, 10 Jun 2024 12:12:58 GMT, Shaojin Wen <duke at openjdk.org> wrote:

> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into primitive arrays by combining values ​​into larger stores.
> 
> This PR rewrites the code of appendNull and append(boolean) methods so that these two methods can be optimized by C2.

>From a compiler point of view, it might be better to enhance the 8318446 optimization so that it recognizes code patterns that use increment.
For a libraries point of view, this proposed change probably needs some comments, so it doesn't get accidentally changed in the future in a way that breaks the optimization.  How would we prevent that?  The situation seems fragile to me.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19626#issuecomment-2159497549