RFR: 8333893: Optimization for StringBuilder append boolean & null [v4]

Shaojin Wen duke at openjdk.org
Tue Jun 11 12:14:14 UTC 2024


On Tue, 11 Jun 2024 11:35:28 GMT, Shaojin Wen <duke at openjdk.org> wrote:

>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into primitive arrays by combining values ​​into larger stores.
>> 
>> This PR rewrites the code of appendNull and append(boolean) methods so that these two methods can be optimized by C2.
>
> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   revert

([f96cde4e](https://git.openjdk.org/jdk/pull/19626/files/f96cde4e79e12e2ea46e6061f918a69f11d59985)) ([0cbaa5ac](https://git.openjdk.org/jdk/pull/19626/files/0cbaa5ac04873373131f1a7216353a5af5b3e48e)) The previous overriding of StringUTF16.putChar method did not improve performance, so I reverted to the original version.

I have collected information on TraceMergeStores, but I don't have enough knowledge to analyze it yet

https://github.com/wenshao/jdk/wiki/pr19626_appendNull_0

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19626#issuecomment-2160603791


More information about the hotspot-compiler-dev mailing list