RFR: 8333684: C2 SuperWord: multiple smaller refactorings in preparation for JDK-8332163 [v2]

[Emanuel Peter]

On Wed, 12 Jun 2024 12:14:52 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/superword.cpp line 1637:
>> 
>>> 1635: 
>>> 1636: VTransformBoolTest PackSet::get_bool_test(const Node_List* bool_pack) const {
>>> 1637:   BoolNode* bol0 = bool_pack->at(0)->as_Bool();
>> 
>> Not sure if the `0` postfix is necessary since you do not use any other nodes of the pack where it is necessary to distinguish different nodes in the pack.
>
> I would like to keep it. Yes, there is use of the other nodes in the `ASSERT` block below.

I'll change it to `bol`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19573#discussion_r1636386453