RFR: 8331117: [PPC64] secondary_super_cache does not scale well [v4]

[Martin Doerr]

On Wed, 12 Jun 2024 14:14:25 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix check for sign bit.
>
> src/hotspot/cpu/ppc/macroAssembler_ppc.cpp line 2210:
> 
>> 2208:   // data.
>> 2209:   assert(Array<Klass*>::base_offset_in_bytes() == wordSize, "Adjust this code");
>> 2210:   assert(Array<Klass*>::length_offset_in_bytes() == 0, "Adjust this code");
> 
> I don't understand why the assertion for `Array<Klass*>::length_offset_in_bytes()` is needed.
> Isn't it sufficient to assert `Array<Klass*>::base_offset_in_bytes() == wordSize`?
> What would break if `Array<Klass*>::length_offset_in_bytes() == 4`?

The assertion is pointless. I've removed it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19368#discussion_r1636589017