RFR: 8333729: C2 SuperWord: remove some @requires usages in test/hotspot/jtreg/compiler/loopopts/superword

Vladimir Kozlov kvn at openjdk.org
Wed Jun 12 14:53:14 UTC 2024


On Thu, 6 Jun 2024 15:08:26 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> I'm removing as many `@requires` statements as possible. Generally, they just limit what tests can be executed where, and in most cases such limitations do not make much sense.
> 
> For example, tests should not be limited to `@requires vm.compiler2.enabled`, i.e. only run if C2 is available - we can also run the tests if GraalVM is available.
> 
> We should also not limit tests to `@requires vm.bits == "64"`, but rather limit the `@IR` rules with `applyIfPlatform = {"64-bit", "true"}`.
> 
> Similarly, we should not limit the platform for a run statement, but do that per `@IR` rule if necessary.

test/hotspot/jtreg/compiler/loopopts/superword/CoLocatePackMemoryState.java line 27:

> 25: /**
> 26:  * @test
> 27:  * @requires vm.compiler2.enabled

Some tests uses this requires when they use C2 specific flags. Like in this case: `LoopMaxUnroll` is C2 flag.
If you want to run such tests with any VM (which may not include C2) you need to add `-XX:+IgnoreUnrecognizedVMOptions`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19581#discussion_r1636627038


More information about the hotspot-compiler-dev mailing list