RFR: 8333729: C2 SuperWord: remove some @requires usages in test/hotspot/jtreg/compiler/loopopts/superword

Emanuel Peter epeter at openjdk.org
Wed Jun 12 15:16:15 UTC 2024


On Wed, 12 Jun 2024 14:54:04 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> I'm removing as many `@requires` statements as possible. Generally, they just limit what tests can be executed where, and in most cases such limitations do not make much sense.
>> 
>> For example, tests should not be limited to `@requires vm.compiler2.enabled`, i.e. only run if C2 is available - we can also run the tests if GraalVM is available.
>> 
>> We should also not limit tests to `@requires vm.bits == "64"`, but rather limit the `@IR` rules with `applyIfPlatform = {"64-bit", "true"}`.
>> 
>> Similarly, we should not limit the platform for a run statement, but do that per `@IR` rule if necessary.
>
> I suggest to build VM without C2 and run these modified tests with to find missing `-XX:+IgnoreUnrecognizedVMOptions` flag and other failure modes.
> 
> Also build and run 32-bit VM with these tests too.

@vnkozlov Ok, I can do that. Would be nice if we had such testing automatically in our testing though - build and test without C2.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19581#issuecomment-2163295158


More information about the hotspot-compiler-dev mailing list