RFR: 8333840: C2 SuperWord: wrong result for MulAddS2I when inputs permuted [v6]

Vladimir Kozlov kvn at openjdk.org
Thu Jun 13 14:49:13 UTC 2024


On Thu, 13 Jun 2024 14:36:25 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> This is an older bug, I discovered it by manual code inspection while refactoring.
>> 
>> I added some regression tests that produced wrong results.
>> 
>> You should understand the fix given the comments in the code, if not: tell me how to improve them ;)
>
> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Apply suggestions from code review
>   
>   Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>

Latest changes look good.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19619#pullrequestreview-2116026372


More information about the hotspot-compiler-dev mailing list