RFR: 8333729: C2 SuperWord: remove some @requires usages in test/hotspot/jtreg/compiler/loopopts/superword [v3]

Emanuel Peter epeter at openjdk.org
Thu Jun 13 18:28:40 UTC 2024


> I'm removing as many `@requires` statements as possible. Generally, they just limit what tests can be executed where, and in most cases such limitations do not make much sense.
> 
> For example, tests should not be limited to `@requires vm.compiler2.enabled`, i.e. only run if C2 is available - we can also run the tests if GraalVM is available.
> 
> We should also not limit tests to `@requires vm.bits == "64"`, but rather limit the `@IR` rules with `applyIfPlatform = {"64-bit", "true"}`.
> 
> Similarly, we should not limit the platform for a run statement, but do that per `@IR` rule if necessary.

Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:

  fix some more tests

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19581/files
  - new: https://git.openjdk.org/jdk/pull/19581/files/2733a868..7b54425b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19581&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19581&range=01-02

  Stats: 53 lines in 16 files changed: 22 ins; 2 del; 29 mod
  Patch: https://git.openjdk.org/jdk/pull/19581.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19581/head:pull/19581

PR: https://git.openjdk.org/jdk/pull/19581


More information about the hotspot-compiler-dev mailing list