RFR: 8333477: Delete extra empty spaces in Makefiles [v2]
Magnus Ihse Bursie
ihse at openjdk.org
Fri Jun 14 10:55:22 UTC 2024
On Fri, 7 Jun 2024 13:34:45 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> I find the extra trailing newlines through below shell command:
>>
>> for i in `find . -iname "Makefile*" | sed "/./build/d"` ; do tail -n 2 $i | grep -c "^$" | grep -q "^1$" ; if [[ 0 -eq $? ]] ; then echo $i ; fi ; done
>>
>>
>> There are only two files has been found:
>>
>> ./test/jdk/java/rmi/reliability/benchmark/bench/rmi/Makefile
>> ./test/jdk/java/rmi/reliability/benchmark/bench/Makefile
>
> Ah, I had not realized that there was more than 1 newline. GitHub's UI confused me here, so we're good to go
GitHub's UI assumes the final line has an line break. If it is missing, it displays a red 🚫 at the end of the last line. If there is an empty line showing up in the UI, then it is an additional empty line.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19537#discussion_r1639649265
More information about the hotspot-compiler-dev
mailing list