RFR: 8317720: RISC-V: Implement Adler32 intrinsic [v11]

[Fei Yang]

On Thu, 13 Jun 2024 11:27:49 GMT, ArsenyBochkarev <duke at openjdk.org> wrote:

>> Hello everyone! Please review this ~non-vectorized~ implementation of `_updateBytesAdler32` intrinsic. Reference implementation for AArch64 can be found [here](https://github.com/openjdk/jdk9/blob/master/hotspot/src/cpu/aarch64/vm/stubGenerator_aarch64.cpp#L3281).
>> 
>> ### Correctness checks
>> 
>> Test `test/hotspot/jtreg/compiler/intrinsics/zip/TestAdler32.java` is ok. All tier1 also passed.
>> 
>> ### Performance results on T-Head board
>> 
>> Enabled intrinsic:
>> 
>> | Benchmark                          |    (count) |  Mode |  Cnt  |   Score  |  Error |  Units |
>> | ------------------------------------- | ----------- | ------ | --------- | ------ | --------- | ---------- |
>> | Adler32.TestAdler32.testAdler32Update |      64 | thrpt  | 25 | 5522.693 | 23.387 | ops/ms |
>> | Adler32.TestAdler32.testAdler32Update |     128 | thrpt |  25 | 3430.761 |  9.210 | ops/ms |
>> | Adler32.TestAdler32.testAdler32Update |     256 | thrpt |  25 | 1962.888 |  5.323 | ops/ms |
>> | Adler32.TestAdler32.testAdler32Update |     512 | thrpt  | 25 | 1050.938 |  0.144 | ops/ms |
>> | Adler32.TestAdler32.testAdler32Update |    1024 | thrpt  | 25 |  549.227 |  0.375 | ops/ms |
>> | Adler32.TestAdler32.testAdler32Update |    2048 | thrpt  | 25 |  280.829 |  0.170 | ops/ms |
>> | Adler32.TestAdler32.testAdler32Update |    5012 | thrpt  | 25 |  116.333 |  0.057 | ops/ms |
>> | Adler32.TestAdler32.testAdler32Update |    8192 | thrpt  | 25  |  71.392 |  0.060 | ops/ms |
>> | Adler32.TestAdler32.testAdler32Update |   16384 | thrpt |  25  |  35.784 |  0.019 | ops/ms |
>> | Adler32.TestAdler32.testAdler32Update |   32768 | thrpt |  25  |  17.924 |  0.010 | ops/ms |
>> | Adler32.TestAdler32.testAdler32Update  |  65536 | thrpt |  25  |   8.940 |  0.003 | ops/ms |
>> 
>> Disabled intrinsic:
>> 
>> | Benchmark                          |    (count) |  Mode |  Cnt  |   Score  |  Error |  Units |
>> | ------------------------------------- | ----------- | ------ | --------- | ------ | --------- | ---------- |
>> |Adler32.TestAdler32.testAdler32Update|64|thrpt|25|655.633|5.845|ops/ms|
>> |Adler32.TestAdler32.testAdler32Update|128|thrpt|25|587.418|10.062|ops/ms|
>> |Adler32.TestAdler32.testAdler32Update|256|thrpt|25|546.675|11.598|ops/ms|
>> |Adler32.TestAdler32.testAdler32Update|512|thrpt|25|432.328|11.517|ops/ms|
>> |Adler32.TestAdler32.testAdler32Update|1024|thrpt|25|311.771|4.238|ops/ms|
>> |Adler32.TestAdler32.testAdler32Update|2048|thrpt|25|202.648|2.486|ops/ms|
>> |Adler32.TestAdler32.testAdler32Update|5012|thrpt|...
>
> ArsenyBochkarev has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Dispose of right_16_bits register reserve
>  - Unify process_bytes func for different step sizes

Here you go. JMH data for the latest version:

Before:

Benchmark                      (count)   Mode  Cnt     Score    Error   Units
TestAdler32.testAdler32Update       64  thrpt   25  1839.455 ± 30.002  ops/ms
TestAdler32.testAdler32Update      128  thrpt   25  1633.132 ± 24.443  ops/ms
TestAdler32.testAdler32Update      256  thrpt   25  1312.842 ±  9.129  ops/ms
TestAdler32.testAdler32Update      512  thrpt   25   979.352 ±  8.982  ops/ms
TestAdler32.testAdler32Update     1024  thrpt   25   642.716 ±  0.414  ops/ms
TestAdler32.testAdler32Update     2048  thrpt   25   378.849 ±  1.095  ops/ms
TestAdler32.testAdler32Update     5012  thrpt   25   171.918 ±  0.479  ops/ms
TestAdler32.testAdler32Update     8192  thrpt   25   108.965 ±  0.084  ops/ms
TestAdler32.testAdler32Update    16384  thrpt   25    55.839 ±  0.185  ops/ms
TestAdler32.testAdler32Update    32768  thrpt   25    26.950 ±  0.069  ops/ms
TestAdler32.testAdler32Update    65536  thrpt   25    13.462 ±  0.020  ops/ms

After:

Benchmark                      (count)   Mode  Cnt     Score    Error   Units
TestAdler32.testAdler32Update       64  thrpt   25  7952.749 ± 18.472  ops/ms
TestAdler32.testAdler32Update      128  thrpt   25  6140.881 ± 74.067  ops/ms
TestAdler32.testAdler32Update      256  thrpt   25  4397.484 ± 32.142  ops/ms
TestAdler32.testAdler32Update      512  thrpt   25  2808.776 ±  0.749  ops/ms
TestAdler32.testAdler32Update     1024  thrpt   25  1636.976 ±  4.634  ops/ms
TestAdler32.testAdler32Update     2048  thrpt   25   891.656 ±  1.636  ops/ms
TestAdler32.testAdler32Update     5012  thrpt   25   382.059 ±  0.644  ops/ms
TestAdler32.testAdler32Update     8192  thrpt   25   237.452 ±  0.085  ops/ms
TestAdler32.testAdler32Update    16384  thrpt   25   120.433 ±  0.288  ops/ms
TestAdler32.testAdler32Update    32768  thrpt   25    58.892 ±  0.052  ops/ms
TestAdler32.testAdler32Update    65536  thrpt   25    29.891 ±  0.011  ops/ms

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18382#issuecomment-2167779992