RFR: 8333334: C2: Make result of `Node::dominates` more precise to enhance scalar replacement [v3]

[Tobias Hartmann]

On Fri, 14 Jun 2024 10:18:29 GMT, Qizheng Xing <qxing at openjdk.org> wrote:

> Am I missing something? Sorry for not familiar with the IR testing framework, maybe providing an option to match allocations at exact locations would help to build this test.

I don't have time to look into this in detail right now but usually such issue come from a method not being inlined (in that case you need to enforce inlining via [@ForceInline](https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/compiler/lib/ir_framework/ForceInline.java) or via compile commands) or because an uncommon trap is added. You should be able to see that in the IR dump.

> BTW, could you observe the performance improvement in ConcurrentHashMap iteration after applying this patch to your JDK?

No, I didn't get a chance to try this out yet.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19496#issuecomment-2172353020