Integrated: 8333729: C2 SuperWord: remove some @requires usages in test/hotspot/jtreg/compiler/loopopts/superword
Emanuel Peter
epeter at openjdk.org
Mon Jun 17 07:02:19 UTC 2024
On Thu, 6 Jun 2024 15:08:26 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
> I'm removing as many `@requires` statements as possible. Generally, they just limit what tests can be executed where, and in most cases such limitations do not make much sense.
>
> For example, tests should not be limited to `@requires vm.compiler2.enabled`, i.e. only run if C2 is available - we can also run the tests if GraalVM is available.
>
> We should also not limit tests to `@requires vm.bits == "64"`, but rather limit the `@IR` rules with `applyIfPlatform = {"64-bit", "true"}`.
>
> Similarly, we should not limit the platform for a run statement, but do that per `@IR` rule if necessary.
>
> Update: I had to add some extra `-XX:+IgnoreUnrecognizedVMOptions`, so that the C2 flags do not make the VM crash if C2 is not available. I ran all the relevant tests on a build without C2, see discussion in the thread below.
This pull request has now been integrated.
Changeset: 7b38bfea
Author: Emanuel Peter <epeter at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/7b38bfea331437ad99277032de7fce939303abc8
Stats: 110 lines in 22 files changed: 42 ins; 34 del; 34 mod
8333729: C2 SuperWord: remove some @requires usages in test/hotspot/jtreg/compiler/loopopts/superword
Reviewed-by: chagedorn, kvn
-------------
PR: https://git.openjdk.org/jdk/pull/19581
More information about the hotspot-compiler-dev
mailing list