RFR: 8331168: Introduce PredicateEntryIterator to iterate through predicate entries [v2]

[Roland Westrelin]

On Mon, 17 Jun 2024 11:00:59 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> This is another small PR split off from the complete fix for Assertion Predicates.
>> 
>> Changes include:
>> - Replace predicate matching/skipping code in `build_loop_late_post_work()` to use dedicated walker (i.e. new `PredicateEntryIterator` class) which uses predicate classes.
>> - New predicate helper classes to improve readability.
>> - Simple typos and code style updates.
>> 
>> Thanks,
>> Christian
>
> Christian Hagedorn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Introduce is_strict_dominator()
>  - Merge branch 'master' into JDK-8331168
>  - 8331168: Introduce PredicateEntryIterator to iterate through predicate entries

Looks good to me.

-------------

Marked as reviewed by roland (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19716#pullrequestreview-2125338016