RFR: 8327381: Refactor type-improving transformations in BoolNode::Ideal to BoolNode::Value [v10]

[Kangcheng Xu]

On Fri, 14 Jun 2024 07:08:33 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Kangcheng Xu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 18 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into boolnode-refactor
>>  - move test location, add negative test case, simplify imports
>>  - Merge branch 'master' into boolnode-refactor
>>  - refactor BoolNode::Value() and extract code to ::Value_cmpu_and_mask
>>  - update comments
>>  - fix indentation again
>>  - apply test only on x64, aarch64 and riscv64
>>  - also renames the class name in @run
>>  - update test @run annotation
>>  - improve formatting, correct annotation and rename test class
>>  - ... and 8 more: https://git.openjdk.org/jdk/compare/fe4260fc...84784c74
>
> test/hotspot/jtreg/compiler/c2/gvn/TestBoolNodeGVN.java line 71:
> 
>> 69: 
>> 70:     private static void testCorrectness() {
>> 71:         int[] values = { 0, 1, 5, 8, 16, 42, 100, Integer.MAX_VALUE };
> 
> What about adding a random value, and negative nunmbers (i.e. such that they go into the upper range of unsigned)?

I added a random value. However, I'd avoid negatives here since it would create confusion to be used with unsigned comparisons.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18198#discussion_r1644557506