RFR: 8334564: VM startup: fatal error: FLAG_SET_ERGO cannot be used to set an invalid value for NonNMethodCodeHeapSize [v2]

[Thomas Stuefe]

On Thu, 20 Jun 2024 16:56:36 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

>> CodeHeap segment sizes are aligned to page size multiples. This can result in the non-nmethod segment receiving size 0 (zero). Range checking during FLAG_SET_ERGO processing detects that and raises an error, preventing the vm from starting.
>> 
>> This fix increases the minimum size of the non-nmethod segment to page size, preventing it from being rounded down to zero.
>> 
>> Verified by manual testing. Nightly tests (mainly to discover unexpected side effects) pending.
>
> Lutz Schmidt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8334564: Remove extra whitespace.

+1

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19812#pullrequestreview-2130941601