Integrated: 8334706: [JVMCI] APX registers incorrectly exposed on AMD64
Doug Simon
dnsimon at openjdk.org
Fri Jun 21 13:46:15 UTC 2024
On Fri, 21 Jun 2024 10:01:06 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
> This PR fixes a bug introduced by [JDK-8329032](https://bugs.openjdk.org/browse/JDK-8329032) which added the APX registers to `AMD64.java`.
> It broke [this invariant](https://github.com/openjdk/jdk/blob/d2bebffb1fd26fae4526afd33a818ee776b7102e/src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/code/Architecture.java#L48-L52):
>
> /**
> * List of all available registers on this architecture. The index of each register in this list
> * is equal to its {@linkplain Register#number number}.
> */
> private final RegisterArray registers;
>
> That invariant is relied upon by the Graal register allocator.
> This PR now tests the invariant and fixes the definitions in `AMD64.java` that were violating it.
>
> This fix was developed by @tkrodriguez.
This pull request has now been integrated.
Changeset: dbf5a9a4
Author: Doug Simon <dnsimon at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/dbf5a9a4006020ddebcce89692ce8826b6b2db46
Stats: 16 lines in 2 files changed: 11 ins; 4 del; 1 mod
8334706: [JVMCI] APX registers incorrectly exposed on AMD64
Reviewed-by: yzheng, never
-------------
PR: https://git.openjdk.org/jdk/pull/19824
More information about the hotspot-compiler-dev
mailing list