RFR: 8333258: C2: high memory usage in PhaseCFG::insert_anti_dependences() [v2]

Vladimir Kozlov kvn at openjdk.org
Tue Jun 25 14:00:18 UTC 2024


On Tue, 25 Jun 2024 13:53:09 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Seems my old comments have disappeared, and with them Roland's answers.
>> 
>> Roland said duplicates are ok. But if you @vnkozlov are asking, then @rwestrel needs to make a comment about why we can early exit here ;)
>
> Ah, it the comment is still here:
> https://github.com/openjdk/jdk/pull/19791#issuecomment-2180754800

I think the last statement in comment is not correct.
You can push several `(mem, store)` with the same memory. Then you pop only one top pair and start processing it which leads to different memory in `(mem, store)` pairs pushed on worklist. After processing some of pairs you may see original memory node again.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19791#discussion_r1652874066


More information about the hotspot-compiler-dev mailing list