RFR: 8321509: False positive in get_trampoline fast path causes crash [v2]

[Vladimir Kozlov]

On Tue, 25 Jun 2024 20:48:34 GMT, Dean Long <dlong at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/nativeInst_aarch64.cpp line 110:
>> 
>>> 108:   CodeBlob *code = CodeCache::find_blob(call_addr);
>>> 109:   assert(code != nullptr, "Could not find the containing code blob");
>>> 110:   if (!code->is_nmethod()) return nullptr;
>> 
>> Is it because trampolines are not used by not nmethods? Should we have an assert here about that?
>
> Previously, get_trampoline() was called on CodeBuffer/CodeBlob during expansion, but now it is only called by set_destination_mt_safe, so it should be OK to assert that it is an nmethod.

Good.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19796#discussion_r1653608107