RFR: 8334647: C2: CastII added by PhaseIdealLoop::add_template_assertion_predicate() should have control [v2]

[Christian Hagedorn]

On Tue, 25 Jun 2024 11:54:19 GMT, Roland Westrelin <roland at openjdk.org> wrote:

> Mandating control on all `ConstraintCastNode` sounds reasonable but I have no idea what control would make sense for the case above so maybe it's too constraining to always have to set the control.

Maybe it is, I'm not sure about this case, either. But if this is the only case we could think about just adding the same assert you've inserted for `CastII/LL` at the other `ConstraintCastNodes` (except for `CastPP` due to this unclear case). What do you think about that? This could ensure that if someone is adding any such node without control, they need a good reason to not add a control instead of the other way round.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19808#issuecomment-2190975673