RFR: 8335220: C2: Missing check for Opaque4 node in EscapeAnalysis [v2]

[Vladimir Kozlov]

On Thu, 27 Jun 2024 07:40:52 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add comment about Opaque4
>
> src/hotspot/share/opto/escape.cpp line 581:
> 
>> 579:             Node* iff_cmp = iff->in(1)->in(1);
>> 580:             int opc = iff_cmp->Opcode();
>> 581:             can_reduce = (opc == Op_CmpP || opc == Op_CmpN) && can_reduce_cmp(n, iff_cmp);
> 
> Can you add a comment here that we could have an `Opaque4` node for which we want to bail out?

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19921#discussion_r1657292704