RFR: 8335221: Some C2 intrinsics incorrectly assume that type argument is compile-time constant [v2]

[Vladimir Kozlov]

On Fri, 28 Jun 2024 09:21:25 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move common checks into shared method
>
> src/hotspot/share/opto/library_call.cpp line 5494:
> 
>> 5492: // Common checks for array sorting intrinsics arguments.
>> 5493: // Returns `true` if checks passed.
>> 5494: bool LibraryCallKit::check_array_sort_arguments(Node* elementType, Node* obj, BasicType* bt) {
> 
> Thanks for doing the update, looks good! Just one small detail: You could use a reference here instead of a pointer. Then you can pass `bt` in and modify it directly.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19918#discussion_r1659072580