RFR: 8334816: compiler/c2/irTests/TestIfMinMax.java fails after 8334629

Jasmine Karthikeyan jkarthikeyan at openjdk.org
Sun Jun 30 02:44:40 UTC 2024


This PR fixes an issue discovered during the review of #19650, where TestIfMinMax produced some IR failures. This issue is similar to the one in #18734, where a rare case could cause the same failure when the branch taken percent was too low. The fix there was to add 50 positive and 50 negative elements to the array, which guarantees that the IfNode will have a branch probability of at least 0.098. However, since the threshold has been increased from 0.01 to 0.18, the amount of sequential elements needs to be increased. I've increased it to 125 so the probability is guaranteed to be at least 0.24, which is larger than the threshold needed to convert to CMove.

Thoughts and reviews would be appreciated!

-------------

Commit messages:
 - Fix JDK-8334816

Changes: https://git.openjdk.org/jdk/pull/19959/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19959&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8334816
  Stats: 13 lines in 2 files changed: 0 ins; 1 del; 12 mod
  Patch: https://git.openjdk.org/jdk/pull/19959.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19959/head:pull/19959

PR: https://git.openjdk.org/jdk/pull/19959


More information about the hotspot-compiler-dev mailing list