RFR: 8323220: Reassociate loop invariants involved in Cmps and Add/Subs [v5]

Joshua Cao duke at openjdk.org
Fri Mar 1 00:27:53 UTC 2024


On Thu, 29 Feb 2024 07:26:52 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> One more concern I just had: do we have tests for the pre-existing Add/Sub reassociations?

Not that I know of. A bunch of reassociation was added in https://github.com/openjdk/jdk/commit/23ed3a9e91ac57295d274fefdf6c0a322b1e87b7, which does not have any tests.

I ran `make CONF=linux-x86_64-server-fastdebug test TEST=all TEST_VM_OPTS=-XX:-TieredCompilation` on my Linux machine. I have 4 failures in `SctpChannel` and 3 failures in `CAInterop.java`, but they also fail on master branch so they should not be caused by this patch. Hopefully this adds a little more confidence.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17375#issuecomment-1972204471


More information about the hotspot-compiler-dev mailing list