Integrated: 8324790: ifnode::fold_compares_helper cleanup
Joshua Cao
duke at openjdk.org
Fri Mar 1 05:38:53 UTC 2024
On Fri, 26 Jan 2024 23:31:00 GMT, Joshua Cao <duke at openjdk.org> wrote:
> I hope my assumptions in `filtered_int_type` are correct here:
>
> * we assert that `if_proj` is an `IfTrue` or `IfFalse`, so it is safe to assume `if_proj->_in` is an `IfNode`
> * the 1'th input of a CmpNode is a BoolNode
> * Tthe 1'th input of an IfNode is **not always a BoolNode**, it can be a constant. We need to leave this check in.
>
> We also remove a some of the if-checks in `compare_folds_cleanup` which seem unnecessary.
>
> Passes tier1 locally.
This pull request has now been integrated.
Changeset: 12404a5e
Author: Joshua Cao <joshcao at amazon.com>
Committer: Emanuel Peter <epeter at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/12404a5efb3c45f72f54fda3238c72d5d15a30ee
Stats: 64 lines in 1 file changed: 21 ins; 27 del; 16 mod
8324790: ifnode::fold_compares_helper cleanup
Reviewed-by: chagedorn, epeter
-------------
PR: https://git.openjdk.org/jdk/pull/17601
More information about the hotspot-compiler-dev
mailing list