RFR: 8327108: compiler.lib.ir_framework.shared.TestFrameworkSocket should listen on loopback address only

Jaikiran Pai jpai at openjdk.org
Fri Mar 1 12:56:11 UTC 2024


Can I please get a review of this test-only change which proposes to address https://bugs.openjdk.org/browse/JDK-8327108?

As noted in the JBS issue, before this proposed change, the internal test framework code in `compiler.lib.ir_framework.shared.TestFrameworkSocket` was binding a `java.net.ServerSocket` to "any address". This can lead to interference  from other hosts on the network, when the tests are run. The change here proposes to bind this `ServerSocket` to loopback address and reduce the chances of such interference.

Originally, the interference issues were noticed in CI when `tier3` was run. With the change proposed in this PR, I've run `tier1`, `tier2` and `tier3` in our CI environment and they all passed.

-------------

Commit messages:
 - 8327108: compiler.lib.ir_framework.shared.TestFrameworkSocket should listen on loopback address only

Changes: https://git.openjdk.org/jdk/pull/18078/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18078&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327108
  Stats: 7 lines in 1 file changed: 3 ins; 1 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18078.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18078/head:pull/18078

PR: https://git.openjdk.org/jdk/pull/18078


More information about the hotspot-compiler-dev mailing list