RFR: 8327109: Refactor data graph cloning used in create_new_if_for_predicate() into separate class
Emanuel Peter
epeter at openjdk.org
Fri Mar 1 14:14:56 UTC 2024
On Fri, 1 Mar 2024 13:58:09 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> The name could mention that we are cloning. And maybe you could do the work in the constructor, and just have accessors for the finished products, such as `_orig_to_new`.
>
> Suggestion for better name `CloneDataNodeGraph`. Do you assert that only data nodes are cloned, and no CFG nodes?
Yes, you do verify it, great!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18080#discussion_r1509050744
More information about the hotspot-compiler-dev
mailing list