RFR: 8327105: compiler.compilercontrol.share.scenario.Executor should listen on loopback address only
Vladimir Kozlov
kvn at openjdk.org
Fri Mar 1 17:25:42 UTC 2024
On Fri, 1 Mar 2024 13:06:18 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review of this test-only change which proposes to address https://bugs.openjdk.org/browse/JDK-8327105?
>
> The commit here changes the internal test class `compiler.compilercontrol.share.scenario.Executor` to bind to a loopback address to prevent other hosts on the network to unexpected communicate on the `ServerSocket`.
>
> The original interference was noticed in some `tier7` tests which use this `Executor` class. With the change proposed in this PR, `tier1`, `tier2`, `tier3` and `tier7`, `tier8` have been run and that issue hasn't been noticed in this class anymore.
Good.
-------------
Marked as reviewed by kvn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18079#pullrequestreview-1911666478
More information about the hotspot-compiler-dev
mailing list