RFR: 8326692: JVMCI Local.endBci is off-by-one
Doug Simon
dnsimon at openjdk.org
Fri Mar 1 18:54:53 UTC 2024
On Fri, 1 Mar 2024 17:48:51 GMT, Gilles Duboscq <gdub at openjdk.org> wrote:
> In class files, in the local variable table, local variables have a start BCI and a length. The local variable has a value from BCI (inclusive) until BCI + length (exclusive).
> On the other end, JVMCI stores that information in `Local` objects with a start BCI and an end BCI (inclusive).
> Currently the parser just uses BCI+length to compute the end BCI, leading to an off-by-one error.
>
> A simple test checking that the start and end BCIs are within the method's bytecode is added. It fails without the fix.
Thanks for fixing this Gilles.
-------------
Marked as reviewed by dnsimon (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18087#pullrequestreview-1911818421
More information about the hotspot-compiler-dev
mailing list