Integrated: 8327108: compiler.lib.ir_framework.shared.TestFrameworkSocket should listen on loopback address only
Jaikiran Pai
jpai at openjdk.org
Sat Mar 2 01:47:53 UTC 2024
On Fri, 1 Mar 2024 12:50:58 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review of this test-only change which proposes to address https://bugs.openjdk.org/browse/JDK-8327108?
>
> As noted in the JBS issue, before this proposed change, the internal test framework code in `compiler.lib.ir_framework.shared.TestFrameworkSocket` was binding a `java.net.ServerSocket` to "any address". This can lead to interference from other hosts on the network, when the tests are run. The change here proposes to bind this `ServerSocket` to loopback address and reduce the chances of such interference.
>
> Originally, the interference issues were noticed in CI when `tier3` was run. With the change proposed in this PR, I've run `tier1`, `tier2` and `tier3` in our CI environment and they all passed.
This pull request has now been integrated.
Changeset: a9c17a22
Author: Jaikiran Pai <jpai at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/a9c17a22ca8e64d12e28e272e3f4845297290854
Stats: 7 lines in 1 file changed: 3 ins; 1 del; 3 mod
8327108: compiler.lib.ir_framework.shared.TestFrameworkSocket should listen on loopback address only
Reviewed-by: chagedorn, kvn
-------------
PR: https://git.openjdk.org/jdk/pull/18078
More information about the hotspot-compiler-dev
mailing list