RFR: 8319690: [AArch64] C2 compilation hits offset_ok_for_immed: assert "c2 compiler bug"

[Andrew Haley]

On Mon, 4 Mar 2024 09:46:56 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> Taking this over from @fg1417, she seems to be "on leave" according to her GitHub account.
> 
> I'm taking her regression test (she improved the reproducer that I had originally reported the bug with).
> 
> It is ok to just remove the assert, because the address is "sanitized" after the assert, i.e. we use a `lea` instruction to compute the address.
> 
> But I'm simply removing the assert, as suggested in the comments of the previous [PR](https://github.com/openjdk/jdk/pull/16991#issuecomment-1962307596).

Yes, that's right. I wrote that assertion for my own information, this isn't really a bug. I might rework this whole area of the compiler in the future, but there's no urgency. Thanks.

-------------

Marked as reviewed by aph (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18103#pullrequestreview-1914822754