RFR: 8325991: Accelerate Poly1305 on x86_64 using AVX2 instructions [v10]

[Srinivas Vamsi Parasa]

On Fri, 1 Mar 2024 08:16:38 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Srinivas Vamsi Parasa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update description of Poly1305 algo
>
> src/hotspot/cpu/x86/assembler_x86.cpp line 5157:
> 
>> 5155: void Assembler::vpmadd52luq(XMMRegister dst, XMMRegister src1, XMMRegister src2, int vector_len) {
>> 5156:   assert(vector_len == AVX_512bit ? VM_Version::supports_avx512ifma() : VM_Version::supports_avxifma(), "");
>> 5157:   InstructionAttr attributes(vector_len, /* rex_w */ true, /* legacy_mode */ false, /* no_mask_reg */ false, /* uses_vl */ true);
> 
> uses_vl should be false.

Please see the updated assert as suggested for vpmadd52[l/h]uq in the latest commit.

> src/hotspot/cpu/x86/assembler_x86.cpp line 5183:
> 
>> 5181:   assert(vector_len == AVX_512bit ? VM_Version::supports_avx512ifma() : VM_Version::supports_avxifma(), "");
>> 5182:   InstructionMark im(this);
>> 5183:   InstructionAttr attributes(vector_len, /* rex_w */ true, /* legacy_mode */ false, /* no_mask_reg */ false, /* uses_vl */ true);
> 
> uses_vl should be false.

Please see the updated assert as suggested for vpmadd52[l/h]uq in the latest commit.

> src/hotspot/cpu/x86/assembler_x86.cpp line 5191:
> 
>> 5189: 
>> 5190: void Assembler::vpmadd52huq(XMMRegister dst, XMMRegister src1, XMMRegister src2, int vector_len) {
>> 5191:   assert(vector_len == AVX_512bit ? VM_Version::supports_avx512ifma() : VM_Version::supports_avxifma(), "");
> 
> Same as above.

Please see the updated assert as suggested for vpmadd52[l/h]uq in the latest commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17881#discussion_r1511830567
PR Review Comment: https://git.openjdk.org/jdk/pull/17881#discussion_r1511830720
PR Review Comment: https://git.openjdk.org/jdk/pull/17881#discussion_r1511830942