RFR: 8326983: Unused operands reported after JDK-8326135 [v3]

Amit Kumar amitkumar at openjdk.org
Wed Mar 6 02:42:46 UTC 2024


On Tue, 5 Mar 2024 06:44:44 GMT, kuaiwei <duke at openjdk.org> wrote:

>>> @dholmes-ora asked to disable warning by default and I agree.
>> 
>> What I said was that until all the known issues are resolved then the warning should be disabled. If this PR fixes every warning that has been spotted then that is fine - the warning can remain on to detect new problems creeping in. Otherwise issues should be filed to fix all remaining warnings and the warning disabled until they are all addressed. We have been lucky that these unexpected warnings have only caused minimal disruption to our builds.
>
>> @dholmes-ora asked to disable warning by default and I agree.
>> 
>> We can use `AD._disable_warnings` flag to guard these warnings and add corresponding `-w` flag to `adlc` command in `GensrcAdlc.gmk`
> 
> I added check of _disable_warnings in adlc. But not enable it in build script.

@kuaiwei  you need one more approval from **R**eviewer, before integrating hotspot change.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18075#issuecomment-1979975733


More information about the hotspot-compiler-dev mailing list