RFR: 8327283: RISC-V: Minimal build failed after JDK-8319716
Gui Cao
gcao at openjdk.org
Thu Mar 7 09:06:53 UTC 2024
On Wed, 6 Mar 2024 12:20:43 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> The SHA intrinsic are only used in "LibraryCallKit::inline_digestBase_implCompress" and JVMCI.
>> So I think these (plus md5 and chacha) should be put into a ifdef COMPILER2_OR_JVMCI block. (I was going todo that but it slipped my mind)
>>
>> The MaxVectorSize is defined if JVMCI and/or C2 is defined:
>> `NOT_COMPILER2(product(intx, MaxVectorSize, 64,`
>
>> I agree with @robehn ! We can put those functions definitions into a ifdef COMPILER2_OR_JVMCI block to avoid such a problem. I don't see other uses of them for now.
>
> This also makes it clear that C1/interpreter don't use them, hence if someone needs a speed up there they could try to make use of them.
@robehn @RealFYang : Thanks all for the review
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18114#issuecomment-1983032275
More information about the hotspot-compiler-dev
mailing list