RFR: 8324655: Identify integer minimum and maximum patterns created with if statements [v6]

Jasmine Karthikeyan jkarthikeyan at openjdk.org
Thu Mar 7 18:31:00 UTC 2024


On Thu, 7 Mar 2024 08:43:00 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> And then you could actualy move the call to `CMoveNode::Ideal`.
>
> Who knows, maybe we one day extend this to other types

I think moving the call to `CMoveNode::Ideal` would be a good idea, since it de-duplicates the call site. Would it still assert on non-supported types, then? I think it may make more sense if it simply filtered out the cmov types that it doesn't (currently) support.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17574#discussion_r1516631304


More information about the hotspot-compiler-dev mailing list