RFR: 8321021: RISC-V: C2 VectorUCastB2X [v2]

[Gui Cao]

On Wed, 28 Feb 2024 13:26:04 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you help to review the patch to add support for some vector intrinsics?
>> Also complement various tests on riscv.
>> Thanks.
>> 
>> ## Test
>> test/hotspot/jtreg/compiler/vectorapi/
>> test/hotspot/jtreg/compiler/vectorization/
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   modify test config

src/hotspot/cpu/riscv/riscv_v.ad line 3237:

> 3235: // VectorCastS2X, VectorUCastS2X
> 3236: 
> 3237: instruct vcvtStoB(vReg dst, vReg src) %{

Hi, Should use vcvtStoX instead of vcvtStoB?

src/hotspot/cpu/riscv/riscv_v.ad line 3245:

> 3243:   match(Set dst (VectorCastS2X src));
> 3244:   effect(TEMP_DEF dst);
> 3245:   format %{ "vcvtStoB $dst, $src" %}

And Here,  vcvtStoX can be used instead of vcvtStoB.

test/hotspot/jtreg/compiler/vectorapi/reshape/TestVectorCastRVV.java line 37:

> 35:  * @modules java.base/jdk.internal.misc
> 36:  * @summary Test that vector cast intrinsics work as intended on riscv (rvv).
> 37:  * @requires os.arch == "riscv64" & vm.cpu.features ~= ".*v,.*"

is it possible to match rvc here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18040#discussion_r1517116676
PR Review Comment: https://git.openjdk.org/jdk/pull/18040#discussion_r1517117063
PR Review Comment: https://git.openjdk.org/jdk/pull/18040#discussion_r1517117349