RFR: 8325651: C2 SuperWord: refactor the dependency graph [v6]

[Emanuel Peter]

On Thu, 7 Mar 2024 14:19:23 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Apply from Christian's suggestions
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>>  - remove body() accessor from VLoopDependencyGraph, use field directly
>
> src/hotspot/share/opto/vectorization.hpp line 467:
> 
>> 465: 
>> 466:   // Node depth in DAG: bb_idx -> depth
>> 467:   GrowableArray<int> _depth;
> 
> Suggestion:
> 
>   GrowableArray<int> _depths;

done

> src/hotspot/share/opto/vectorization.hpp line 469:
> 
>> 467:   GrowableArray<int> _depth;
>> 468: 
>> 469: protected:
> 
> Why is this protected?

Ha. I thought I needed if for accessing by the inner class in `VLoopDependencyGraph::PredsIterator::next`.
But I can directly access the field there. Removing the accessor.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17812#discussion_r1517224320
PR Review Comment: https://git.openjdk.org/jdk/pull/17812#discussion_r1517223449