RFR: 8325674: Constant fold across compares [v3]

Joshua Cao duke at openjdk.org
Fri Mar 8 18:36:55 UTC 2024


On Thu, 7 Mar 2024 08:28:19 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Joshua Cao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   comments with explanations and style changes
>
> src/hotspot/share/opto/subnode.cpp line 1586:
> 
>> 1584:       }
>> 1585:     }
>> 1586:   }
> 
> This looks like heavy code duplication. Can you refactor this? Maybe a helper method?

I can post a version of this so we can see what it looks like. I actually did this first, but the code got quite ugly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17853#discussion_r1518126089


More information about the hotspot-compiler-dev mailing list