RFR: 8325991: Accelerate Poly1305 on x86_64 using AVX2 instructions [v13]

[Srinivas Vamsi Parasa]

On Tue, 12 Mar 2024 15:59:59 GMT, Tom Shull <duke at openjdk.org> wrote:

>> Srinivas Vamsi Parasa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   make vpmadd52l/hq generic
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 312:
> 
>> 310:     __ lea(rsi, Address(rbp, in_bytes(VM_Version::sef_cpuid7_ecx1_offset())));
>> 311:     __ movl(Address(rsi, 0), rax);
>> 312:     __ movl(Address(rsi, 4), rbx);
> 
> Hi @vamsi-parasa. I believe this code has a bug in it. Here you are copying back all four registers; however, within https://github.com/openjdk/jdk/blob/782206bc97dc6ae953b0c3ce01f8b6edab4ad30b/src/hotspot/cpu/x86/vm_version_x86.hpp#L468 you only created one field.
> 
> Can you please open up a JBS issue to fix this?

Hi Tom (@teshull), 
Thank you for identifying the issue. Please see the JBS issue filed at https://bugs.openjdk.org/browse/JDK-8327999.

Will float a new PR to fix this issue soon.

Thanks,
Vamsi

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17881#discussion_r1521869268