RFR: 8327381 Refactor type-improving transformations in BoolNode::Ideal to BoolNode::Value [v3]
Kangcheng Xu
kxu at openjdk.org
Tue Mar 12 18:43:47 UTC 2024
> This PR resolves [JDK-8327381](https://bugs.openjdk.org/browse/JDK-8327381)
>
> Currently the transformations for expressions with patterns `((x & m) u<= m)` or `((m & x) u<= m)` to `true` is in `BoolNode::Ideal` function with a new constant node of value `1` created. However, this is technically a type-improving (reduction in range) transformation that's better suited in `BoolNode::Value` function.
>
> New unit test `test/hotspot/jtreg/compiler/c2/TestBoolNodeGvn.java` asserting on IR nodes and correctness of this transformation is added and passing.
Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:
modification per code review suggestions
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/18198/files
- new: https://git.openjdk.org/jdk/pull/18198/files/17a9dc37..06b7da36
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=18198&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=18198&range=01-02
Stats: 8 lines in 2 files changed: 1 ins; 0 del; 7 mod
Patch: https://git.openjdk.org/jdk/pull/18198.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/18198/head:pull/18198
PR: https://git.openjdk.org/jdk/pull/18198
More information about the hotspot-compiler-dev
mailing list