RFR: 8327381 Refactor type-improving transformations in BoolNode::Ideal to BoolNode::Value [v2]

[Kangcheng Xu]

On Mon, 11 Mar 2024 21:13:21 GMT, Jasmine Karthikeyan <jkarthikeyan at openjdk.org> wrote:

>> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix test by adding the missing inversion
>>   
>>   also excluding negative values for unsigned comparison
>
> I think the cleanup looks good! I have mostly stylistic suggestions here. Also, the copyright header in `subnode.cpp` should be updated to read 2024.

Thanks @jaskarth and @eme64 for the review. I've pushed a new commit to address the following:

- Updated license header year to 2024
- Explicit `nullptr` comparison
- `Node* var` for pointer types
- Test moved to `c2.irTests`, added `@bug` and `@summary` tags

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18198#issuecomment-1992315599