RFR: 8325438: Add exhaustive tests for Math.round intrinsics [v3]
Hamlin Li
mli at openjdk.org
Tue Mar 12 20:19:17 UTC 2024
On Tue, 12 Mar 2024 16:46:17 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Hamlin Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>>
>> - Merge branch 'master' into round-v-exhaustive-tests
>> - fix issue
>> - mv tests
>> - use IR framework to construct the random tests
>> - Initial commit
>
> test/hotspot/jtreg/compiler/vectorization/TestRoundVectorDoubleRandom.java line 91:
>
>> 89: test_round(res, input);
>> 90: // skip test/verify when warming up
>> 91: if (runInfo.isWarmUp()) {
>
> Hmm. This means that if there is a OSR compilation during warmup, we would not verify. Are we ok with that?
I'm not sure if it's necessary to verify that situation. But, if we verify the result during the warmup, it will rather longer time to finish the test.
Please let me know if we need to verify during warmup.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17753#discussion_r1522060608
More information about the hotspot-compiler-dev
mailing list