RFR: 8325438: Add exhaustive tests for Math.round intrinsics [v4]

Hamlin Li mli at openjdk.org
Wed Mar 13 16:32:51 UTC 2024


On Wed, 13 Mar 2024 06:55:38 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refine code; fix bug
>
> test/hotspot/jtreg/compiler/vectorization/TestRoundVectorDoubleRandom.java line 110:
> 
>> 108:       fis[fidx] = 1 << fidx;
>> 109:     }
>> 110:     fis[fidx++] = 0;
> 
> The zero is now always in the same spot. What if vectorization messes up only in a specific slot, and then never encounters that zero? We would maybe never see a zero in that bad spot.

Good point, will make it random, hope this will resolve the issue.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17753#discussion_r1523577070


More information about the hotspot-compiler-dev mailing list