RFR: 8294976: test/hotspot 183 test classes use ASM [v5]

Oussama Louati duke at openjdk.org
Thu Mar 14 15:13:42 UTC 2024


On Thu, 7 Mar 2024 14:05:18 GMT, Oussama Louati <duke at openjdk.org> wrote:

>> Oussama Louati has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo in error message in GenManyIndyIncorrectBootstrap.java
>
> I ran the JTreg test on this PR Head after full conversion of these tests, and nothing unusual happened, those aren't explicitly related to something else.

> @OssamaLouati thanks for the work you have put into doing this upgrade of the tests. That said I do have a fewconcerns about this change, but let me start by asking you what testing you have performed using the Oracle CI infrastructure? We need to see a full tier 1 - 8 test run on all platforms to ensure this switch is not introducing new timeout failures or OOM conditions, due to the use of this new API. Our`-Xcomp` runs in particular may be adversely affected depending on the number of classes involved compared to ASM.
> 
> This is difficult to review because we lack Hotspot engineers who know the new ClassFile API.

I started running the full tier1-8 tests on mach5, I will wait until the jobs finish and update the Openjdk bug with the confidential comment it with the link.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17834#issuecomment-1997685719


More information about the hotspot-compiler-dev mailing list