RFR: 8308660: C2 compilation hits 'node must be dead' assert [v2]

[Roland Westrelin]

On Thu, 14 Mar 2024 15:13:43 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> Otherwise, looks good!

Thanks for reviewing this.

> test/hotspot/jtreg/compiler/c2/TestFoldIfRemovesTopNode.java line 29:
> 
>> 27:  * @summary C2 compilation hits 'node must be dead' assert
>> 28:  * @run main/othervm -XX:-BackgroundCompilation -XX:-TieredCompilation -XX:-UseOnStackReplacement -XX:+StressIGVN -XX:StressSeed=242006623 TestFoldIfRemovesTopNode
>> 29:  * @run main/othervm -XX:-BackgroundCompilation -XX:-TieredCompilation -XX:-UseOnStackReplacement -XX:+StressIGVN TestFoldIfRemovesTopNode
> 
> You should add `-XX:+UnlockDiagnosticVMOptions` to run with product and either add an `-XX:+IgnoreUnrecognizedVMOptions` or `@requires vm.compiler2.enabled` since `StressIGVN` is a C2 flag.

Right, good catch! Fixed in the new commit.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18305#issuecomment-1997793463
PR Review Comment: https://git.openjdk.org/jdk/pull/18305#discussion_r1525130073