RFR: 8317721: RISC-V: Implement CRC32 intrinsic [v5]

ArsenyBochkarev duke at openjdk.org
Mon Mar 18 13:59:41 UTC 2024


On Wed, 28 Feb 2024 07:05:29 GMT, urniming <duke at openjdk.org> wrote:

>> ArsenyBochkarev has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Re-selected register for tmp's in kernel_crc32
>>  - Use shNadd in update_byte_crc32
>>  - Optimize by1_loop
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.hpp line 1247:
> 
>> 1245:         bool upper);
>> 1246:   void update_byte_crc32(Register crc, Register val, Register table);
>> 1247: 
> 
> Hi, one thing I'm confused about here, why do these three functions need to be in the `COMPILER2` macro ?

Hello! Thanks for pointing this out, I moved these functions up upwards before `#ifdef COMPILER2`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17046#discussion_r1528615445


More information about the hotspot-compiler-dev mailing list