RFR: 8323972: C2 compilation fails with assert(!x->as_Loop()->is_loop_nest_inner_loop()) failed: loop was transformed

[Roland Westrelin]

On Mon, 18 Mar 2024 17:22:45 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> Looks reasonable, but these ad-hoc CastII also make me nervous.
>> 
>> What worries me with adding such "Ad-Hoc" CastII nodes is that elsewhere a very similar computation may not have the same tight type. And then you have a tight type somewhere, and a loose type elsewhere. This is how we get the data-flow collapsing and the cfg not folding.
>
>> Looks reasonable, but these ad-hoc CastII also make me nervous.
> 
> I agree with that. Still feels like the most reasonable fix for this particular issue.

> @rwestrel please wait for our testing to complete, I just launched it.

Thanks for running it. Any update on testing?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17965#issuecomment-2004515234