RFR: 8325438: Add exhaustive tests for Math.round intrinsics [v6]

Hamlin Li mli at openjdk.org
Wed Mar 20 18:54:21 UTC 2024


On Wed, 20 Mar 2024 12:50:53 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Thanks for the suggestion.
>> Unfortunately, I don't have access to a machine with AVX512, but I do run with a aarch64 via qemu where max vector size > 16, and it works with  "-XX:MaxVectorSize=16".
>> The reason why the previous test failed (which I fixed in previous commit) with "-XX:MaxVectorSize=8", is because in test framework, it checks the length of vector and make sure it > length of double(8 bytes), i.e. at least 2*(length of Double).
>
> Can you limit the IR rules, so that the IR rules are only checked if the MaxVectorSize is large enough?
> Example you can look for: `applyIf = {"MaxVectorSize", ">=32"}`
> 
> I think you would just have a `applyIf = {"MaxVectorSize", ">=16"}`.
> I will run the tests on our Oracle machines for AVX512, so don't worry about testing that.
> Maybe you could also simulate a 64 byte register machine with SVE over qemu, but I leave that up to you.

Thanks for the suggestion, it's done.
I also tested with "-XX:MaxVectorSize=64" on aarch64 via qemu, it works.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17753#discussion_r1532632382


More information about the hotspot-compiler-dev mailing list