RFR: 8320725: C2: Add "is_associative" flag for floating-point add-reduction [v3]

Emanuel Peter epeter at openjdk.org
Thu Mar 21 11:37:23 UTC 2024


On Thu, 21 Mar 2024 10:56:40 GMT, Bhavana Kilambi <bkilambi at openjdk.org> wrote:

>> I think you are right. Maybe we can use `ordered/unordered`. I just want to make sure we don't have too many synonyms (ordered, unordered, associative, strictly ordered, etc). But I guess associative and ordered is not exactly a synonym.
>
> Hi, thank you for your comments on this. I personally also feel "is_associative" is a bit non-intuitive as in the reader might have to make the connection between "associativity" and "ordering" compared to the case where we directly use what we intend the variable to do, something like "is_ordered". Would it be okay if I revert this to "requires_strict_order" for the variable and method names that I used in my first commit?

Yes, I think that would be ok.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18034#discussion_r1533719899


More information about the hotspot-compiler-dev mailing list